PDA

View Full Version : [Interface] Setting create game max psr



Theino
11-07-2010, 12:59 PM
Brief Description: In the create game screen, when you select max psr the options show >1900 and >1950 (when they should be <1900 and <1950... like all the other options in max psr)

How to Replicate: Create a game, choose a max psr



Unnecessary things its probably not worth your time to read:

It seems to me the max psr and min psr values are tightly coupled things and the first character in the min psr section should always be > and similarly should be < for everything in the max psr section.

Now, obviously it doesn't take much effort to create a big list of string values (or char* if you're living in the 70s)... but really I think this is code duplication and is prone to errors (see bug report above). Again, maybe this is being silly but it is my opinion that the min psr and max psr sections should use the same list of values. These being 1200, 1300, 1400, etc. The section itself then decides to prepend a < sign or a > sign. Again, this would help serve in the future to overt the horrible problem you're currently having with this typo.


Thanks,
Theino

Vahn
11-08-2010, 03:15 AM
I would say that for min PSR it should say X> and max should be >X.
That way if you had say 1400 - 1600 it will look like 1400> |space| >1600.

Either way the symbols don't all match in the max PSR tab, so confirmed.

Bangerz
11-29-2010, 10:10 PM
public_games.package 1608: Labels on the max psr dropdown are inverted


AddTemplateListItem('Ncombobox_item', '1900', 'label', '&lt;1900');
AddTemplateListItem('Ncombobox_item', '1950', 'label', '&lt;1950');


AddTemplateListItem('Ncombobox_item', '1900', 'label', '&gt;1900');
AddTemplateListItem('Ncombobox_item', '1950', 'label', '&gt;1950');